I'm used to the playstation controllers so currently the ps3 one is my favourite. The gamecube one was good too but the ps2 one was better.
Saying that I've had terrible luck with Gamecube controllers. I have bought 2 different ones so I could play smash bros properly(the ones for the family always end up broken somehow...) But both times the bloody buttons don't work properly. Have to press the L and R buttons the whole way in(requires me to depress them like 2 inches, not good for fast blocking), the A button sometimes decides not to work and the c stick being loose. The ps2 ones were maybe sturdier.